Stop dev from creating unused default bindings dir#5460
Open
clockwork-labs-bot wants to merge 3 commits into
Open
Stop dev from creating unused default bindings dir#5460clockwork-labs-bot wants to merge 3 commits into
clockwork-labs-bot wants to merge 3 commits into
Conversation
clockwork-labs-bot
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
bfops
reviewed
Jun 29, 2026
| } | ||
|
|
||
| if !module_bindings_dir.exists() { | ||
| let should_prepare_module_bindings_dir = |
Collaborator
There was a problem hiding this comment.
I am rather surprised that we addressed this issue, which is about spacetime generate working properly but not spacetime dev's generate, without re-using code from spacetime generate. shouldn't the fix be to share more of the codepaths so the behavior can't deviate?
clockwork-labs-bot
changed the title
bfops
reviewed
Jun 29, 2026
| } | ||
|
|
||
| #[test] | ||
| fn test_create_local_spacetime_config_if_missing_upserts_missing_database() { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Addresses the #3579 report where
spacetime devcreates an empty defaultsrc/module_bindingsdirectory even thoughspacetime generatecorrectly uses the configuredgenerateentries.spacetime devnow prepares the default--module-bindings-pathdirectory only when it will use CLI-driven generation. If generation is driven byspacetime.jsonentries, or generation is skipped,devleaves that default path alone.This addresses part of #3579, but does not close the broader umbrella issue.
API and ABI breaking changes
None.
Expected complexity level and risk
The change is narrowly scoped to
dev's default bindings directory preparation. Config-driven generation behavior is unchanged.Testing
devCLI unit tests from the original patch:PATH=/Users/clockworklabs/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin:$PATH \ cargo check -p spacetimedb-clicargo fmt --allgit diff --check